Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bun file FileFetcher #11287

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add Bun file FileFetcher #11287

merged 1 commit into from
Jan 14, 2025

Conversation

markhallen
Copy link
Contributor

What are you trying to accomplish?

This PR adds the fetcher for bun.lock files. A later PR will add support for legacy bun.lockb files.

We are limiting fetching the bun files with the experiment bun_updates as an experimental feature.

Anything you want to highlight for special attention from reviewers?

  • Is the usage of Experiments.enabled?(:bun_updates) sufficient?

For wider context you can check #11209 or #11248

The ultimate plan is to use a new structure for multiple Javascript ecosystems similar to #1862.

This PR was put together before the change in approach. It was decided that we proceed with these PR's as-is.

We will then follow-up with a PR migrating to the new structure. This migration PR will then serve as an example for the migration of the other Javascript ecosystems.

How will you know you've accomplished your goal?

The new specs should pass and the existing specs should be unimpacted.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 13, 2025 14:51
Base automatically changed from add-bun-file-parser to main January 13, 2025 15:25
@markhallen markhallen dismissed thavaahariharangit’s stale review January 13, 2025 15:25

The base branch was changed.

Co-authored-by: Ashcon Partovi <[email protected]>
@markhallen markhallen force-pushed the add-bun-file-fetcher branch from 8122fe8 to 800dbd5 Compare January 14, 2025 12:08
Copy link
Contributor

@thavaahariharangit thavaahariharangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markhallen markhallen merged commit 492491c into main Jan 14, 2025
68 checks passed
@markhallen markhallen deleted the add-bun-file-fetcher branch January 14, 2025 14:01
This was referenced Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants