Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Hex Erlang to 25 #11308

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Bump Hex Erlang to 25 #11308

merged 2 commits into from
Jan 16, 2025

Conversation

TylerWitt
Copy link
Contributor

@TylerWitt TylerWitt commented Jan 15, 2025

What are you trying to accomplish?

This is a baby step on the way to Elixir 1.18 (#11295). I've found that the jump of 4 minor versions and a handful of erlang versions is a lot of debugging. I also think that handling the upgrade in smaller steps will lead to a better git history anyways.

Currently we are using Erlang 24 from apt, and there are notes that we should not use ESL for this version of Ubuntu, but times have changed and ESL seems to have caught up. This change re-implements ESL and bumps Erlang to 25.

I think ESL is the best way forward outside of using the RabbitMQ erlang solutions (which I'm fine with doing if desired, I'm just more familiar with ESL).

This also bumps Elixir by a patch version (1.14.4 -> 1.14.5)

The next step in this journey is to bump Elixir to 1.15--this change was primarily to isolate the diff for switching to ESL. The minimum Jammy ESL version ended up being 25.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Currently we are using 24 from apt, and there are notes that we should not use ESL for this version of Ubuntu, but times have changed and ESL seems to have caught up.

I think ESL is the best way forward outside of using the RabbitMQ erlang solutions (which I'm fine with doing if desired, I'm just more familiar with ESL).

This also bumps Elixir by a patch version.
@TylerWitt TylerWitt requested a review from a team as a code owner January 15, 2025 12:48
@github-actions github-actions bot added the L: elixir:hex Elixir packages via hex label Jan 15, 2025
@thavaahariharangit thavaahariharangit self-assigned this Jan 15, 2025
@thavaahariharangit thavaahariharangit merged commit 1b47713 into dependabot:main Jan 16, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elixir:hex Elixir packages via hex
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants