Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes [1.3k weekly errors] [JS] Adds error handlers for PNPM exceptions #11316

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fixes [1.3k weekly errors] [JS] Adds error handlers for PNPM exceptions #11316

merged 2 commits into from
Jan 16, 2025
+796 −6

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 16, 2025 •
edited
Loading

What are you trying to accomplish?

Fixes exceptions handler related to pnpm related exceptions

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 16, 2025
@sachin-sandhu sachin-sandhu changed the title Adds error handlers for pnpm exceptions Fixes [1.3k weekly errors] [JS] Adds error handlers for PNPM exceptions Jan 16, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fixes-pnpm-exceptions-errors branch from 07024df to 319bae5 Compare January 16, 2025 15:26
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 16, 2025 15:43
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 16, 2025 15:43
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fixes-pnpm-exceptions-errors branch from 4938ef4 to d5f5a93 Compare January 16, 2025 16:07
abdulapopoola
abdulapopoola reviewed Jan 16, 2025
View reviewed changes
npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/pnpm_lockfile_updater.rb
ERR_PNPM_FETCH_500 = /ERR_PNPM_FETCH_500.*GET (?<dependency_url>.*): - 500/
ERR_PNPM_FETCH_502 = /ERR_PNPM_FETCH_502.*GET (?<dependency_url>.*): - 502/
ERR_PNPM_FETCH_503 = /ERR_PNPM_FETCH_503.*GET (?<dependency_url>.*): - 503/
ERR_PNPM_FETCH_401 = /ERR_PNPM_FETCH_401.*GET (?<dependency_url>.*):/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 401 throw a separate error i.e. private_registry_not_configured or not reachable? I think line 51 is already hinting at this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulapopoola , makes sense, will take care of it in next iteration.

@sachin-sandhu sachin-sandhu merged commit 66caeef into main Jan 16, 2025
112 of 113 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/fixes-pnpm-exceptions-errors branch January 16, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@randhircs randhircs randhircs approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachin-sandhu @abdulapopoola @randhircs