Make update-script.rb generic. #712
Conversation
simi
force-pushed
the
dependency-name
branch
5 times, most recently
from
e87f5e0
to
0b0859e
Compare
|
Thanks for submitting! And sorry for the radio silence here. I joined the team recently and trying to catch up on older PRs. My thoughts on this are similar to what I wrote over in #632 (comment). Basically anything that So I think that leaves the access token and the project path. Project path has some complexity around it, since there are multiple deploy targets for this script... so let's punt on that for now and limit the scope of this PR to just the access token. |
| @@ -19,19 +19,19 @@ | |||
| "type" => "git_source", | |||
| "host" => "github.com", | |||
| "username" => "x-access-token", | |||
| "password" => "a-github-access-token" | |||
| "password" => ENV["GITHUB_ACCESS_TOKEN"] # A GitHub access token with read access to public repos | |||
There was a problem hiding this comment.
I'd like to rename this to something more generic than GITHUB_ACCESS_TOKEN since this is really the "repo that you want to update"... and we've got users of this script running it on gitlab, azure devops, bitbucket, etc.
But not quite sure what's best... calling it "source" vs "target" doesn't clarify that this is the repo that's getting updated by Dependabot...
Thoughts?
Should I update README as well?