Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

Support root-namespace parent classes #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/NodeVisitor/ParentClassNameCollectingNodeVisitor.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,19 @@ public function getParentClassNames(): array
sort($uniqueParentClassNames);

// remove native classes
$namespacedClassNames = array_filter(
$uniqueParentClassNames,
fn (string $parentClassName): bool => str_contains($parentClassName, '\\')
staabm marked this conversation as resolved.
Show resolved Hide resolved
);
$namespacedClassNames = [];
foreach($uniqueParentClassNames as $className) {
try {
// @phpstan-ignore-next-line
$reflectionClass = new \ReflectionClass($className);
if ($reflectionClass->isInternal()) {
continue;
}
$namespacedClassNames[] = $className;
} catch (\ReflectionException $e) {
$namespacedClassNames[] = $className;
}
}

// remove obviously vendor names
$namespacedClassNames = array_filter($namespacedClassNames, function (string $className): bool {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

declare(strict_types=1);

namespace TomasVotruba\Finalize\Tests\ParentClassResolver\Fixture;

final class SomeClassWithInternalParent extends \ArrayObject
{
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

declare(strict_types=1);

namespace TomasVotruba\Finalize\Tests\ParentClassResolver\Fixture;

final class SomeClassWithRootNamespaceParent extends \SomeUnknownRootNamespaceClass
{
}
5 changes: 4 additions & 1 deletion tests/ParentClassResolver/ParentClassResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ public function test(): void
$parentClassNames = $this->parentClassResolver->resolve($phpFileInfos, function () {
});

$this->assertSame([SomeParentClass::class], $parentClassNames);
$this->assertSame([
\SomeUnknownRootNamespaceClass::class, // @phpstan-ignore-line
SomeParentClass::class
], $parentClassNames);
}
}
Loading