fix: Home에서 발생한 이슈들을 수정해요. #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlarjsdn3
approved these changes
Oct 16, 2024
|
|
||
| // MARK: - To | ||
|
|
||
| func pop() { |
There was a problem hiding this comment.
pop을 하게 되면 어느 화면으로 가는지 backToHome() 요렇게 적어주실 수 있을까요? 그러면 좀 더 정확하게 플로우를 파악할 수 있어 보여여
There was a problem hiding this comment.
헉,, 명확한게 좋긴 하지만,,,,
만약 두 개의 다른 뷰컨트롤러에서 inputfamilylinknavigator를 사용한다면, back하는 화면이 다를 수도 있지 않을까요?!
| @@ -51,7 +52,14 @@ final class MainNavigator: MainNavigatorProtocol { | |||
| } | |||
|
|
|||
| func missionUnlockedAlert() { | |||
| BBAlert.style(.mission).show() | |||
| let handler: BBAlertActionHandler = { [weak self] alert in | |||
There was a problem hiding this comment.
bbAlerService를 사용하면 조금 더 Rx스럽게 작성하실 수 있어요~ navigator 안에서 호출할 필요도 없어지구요. 나중에 확인해주세요
There was a problem hiding this comment.
아! 찾았습니당 :)
navigator 안에서 호출하지 않아도 되어서 좋네요! 감사합니다
| return isFirstWidgetAlertUseCase.execute() | ||
| .filter { $0 } | ||
| .withUnretained(self) | ||
| .flatMap { _ -> Observable<Mutation> in |
There was a problem hiding this comment.
제가 지난 번에 flatMap(with:) 연산자 새로 만들었어요. 나중에 다른 기능 구현하실 때 참고하세염
|
QA 내용이 |
넵 다음 issue 사항으로 적용할 부분 맞습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😽개요
🛠️작업 내용
위젯 유도창 띄우기
를 추가하였습니다!
이제 위젯 알럿창을 한번도 보지 않은 회원에게는 위젯 유도창 알림이 뜨게 됩니다.
new 표시 띄우기
를 추가하였습니다!
이제 정상적으로 홈화면 네비게이션에 new표시가 뜹니다.
홈 화면 버튼 작동하지 않는 문제
InputFamilyLinkNavigation 추가하여서 문제 해결하였습니다!
이외에도
🟡차후 계획 (Optional)
✅테스트 케이스