refactor : 로그인 시 존재하지 않는 유저는 빈 JWT 리턴하도록 변경 (#62)

depromeet · Jul 20, 2024 · 0b6a973 · 0b6a973
1 parent 20b11af
commit 0b6a973
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...tion/src/main/java/org/depromeet/spot/application/member/controller/MemberController.java b/...tion/src/main/java/org/depromeet/spot/application/member/controller/MemberController.java
@@ -56,7 +56,9 @@ public JwtTokenResponse login(
                     String accessToken) {
 
         Member member = memberUsecase.login(accessToken);
-
+        if (member == null) {
+            return new JwtTokenResponse("");
+        }
         return new JwtTokenResponse(jwtTokenUtil.getJWTToken(member));
     }
 

diff --git a/usecase/src/main/java/org/depromeet/spot/usecase/service/member/MemberService.java b/usecase/src/main/java/org/depromeet/spot/usecase/service/member/MemberService.java
@@ -3,7 +3,6 @@
 import java.util.Optional;
 
 import org.depromeet.spot.common.exception.member.MemberException.MemberNicknameConflictException;
-import org.depromeet.spot.common.exception.member.MemberException.MemberNotFoundException;
 import org.depromeet.spot.domain.member.Member;
 import org.depromeet.spot.usecase.port.in.member.MemberUsecase;
 import org.depromeet.spot.usecase.port.out.member.MemberRepository;
@@ -39,7 +38,9 @@ public Member login(String accessToken) {
         Member memberResult = oauthRepository.getLoginUserInfo(accessToken);
         Optional<Member> existedMember = memberRepository.findByIdToken(memberResult.getIdToken());
         if (existedMember.isEmpty()) {
-            throw new MemberNotFoundException();
+            // TODO : 404 말고 사용되지 않는 Exception 코드가 필요함.
+            //            throw new MemberNotFoundException();
+            return null;
         }
         return existedMember.get();
     }