chore(deps): upgrade eslint #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmetev1
commented
Jun 8, 2023
jmetev1
commented
Jun 8, 2023
jmetev1
commented
Jun 8, 2023
jmetev1
commented
Jun 8, 2023
jmetev1
commented
Jun 8, 2023
|
Thanks for contributing @jmetev1! Normally we would have you apply via our careers page, but I'm not sure where our active listings are. Would you mind submitting your resume to [email protected] ccing [email protected]? We'd love to have you apply! |
scurker
requested changes
Jun 20, 2023
|
this is one of those times where the ui shows "all conversations resolved", but also "scurker requests changes". Is there anything else i need to do here? |
Our process normally has been to have the submitter dismiss the changes, but I'm taking a look right now to ensure we're good. |
scurker
approved these changes
Jul 11, 2023
|
🚨 Reviewed For Security 🚨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks. I see you're hiring. Does this qualify me for an interview for https://www.deque.com/careers/senior-full-stack-developer/ ?
closes #451
I upgraded eslint and plugins. Of course this comes with some new rules and changes. To deal with that I disabled some rules that you were not using previously and made a few other small changes. Let me know if you want any changes. Or just push them.