Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Added tests for all weighting schemes and improved error handling #30

Merged
merged 6 commits into from
Dec 19, 2024
Merged

TEST: Added tests for all weighting schemes and improved error handling #30

merged 6 commits into from
Dec 19, 2024

Conversation

derb12
Copy link
Owner

@derb12 derb12 commented Dec 19, 2024 •
edited
Loading

Description

Added test cases covering all weighting schemes used in pybaselines. Fixed airpls weighting to match the author's intent since the journal article had a typo. Improved error prevention for airpls, arpls, drpls, iarpls, and aspls. Added assymetric_coef parameter for aspls and all of its variants.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Miscellaneous Changes (refactor, code improvements, etc.)
  • Documentation or Example Programs

Pull Request Checklist

  • New code and/or documentation is valid for use with the BSD 3-clause license.
  • New code is fully documented with docstrings that follow Numpy style,
    if applicable.
  • New code follows PEP 8 standards as closely as possible, if applicable.
  • Added/updated tests and ensured they pass locally, if applicable.
  • Verified that documentation builds locally, if applicable.

@derb12
FIX: Corrected airpls weighting
4a0bf54 
The weighting equation for airpls was misprinted in its journal article, so changed to the correct weighting scheme. Also improved overflow avoidance for airpls so that try except blocks are no longer needed, and slightly sped up asls weighting.
@derb12
OTHER: Improved arpls weighting error handling
40d2325
@derb12
OTHER: Made drpls weighting more robust
eb78ce5 
Also improved overflow avoidance for drpls so that try except blocks are no longer needed.
@derb12
OTHER: Made iarpls weighting more robust
23c6c5b 
Improved overflow avoidance for iarpls so that try except blocks are no longer needed. Also removed all skipped tests for 2D Whittaker and spline tests since they had no use.
@derb12
OTHER: Allow inputting assymetric_coef for aspls and pspline_aspls
fcf4cfd 
Also added tests for the aspls weighting.
@derb12
TEST: Added tests for psalsa and derpsalsa weightings
a4413fd
@derb12 derb12 merged commit 380aa5b into development Dec 19, 2024
8 checks passed
@derb12 derb12 deleted the update_weighting branch December 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derb12