chore: fix code smells

deriv-com · Feb 28, 2024 · 1898c11 · 1898c11
1 parent a436664
commit 1898c11
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/botPage/view/log-table.js b/src/botPage/view/log-table.js
@@ -109,6 +109,21 @@ const LogTableContent = () => {
         </div>
     );
 
+    rowRenderer.propTypes = {
+        rowData: PropTypes.shape({
+            type: PropTypes.string,
+        }),
+        columns: PropTypes.shape({
+            props: PropTypes.shape({
+                style: PropTypes.object,
+                className: PropTypes.string,
+                role: PropTypes.string,
+                title: PropTypes.string,
+            }),
+            key: PropTypes.string,
+        }),
+    };
+
     return (
         <span id='logPanel' className='logpanel'>
             <div id='logtable' className='logTable-scroll logtable'>
@@ -130,9 +145,9 @@ const LogTableContent = () => {
                                     rowRenderer={rowRenderer}
                                     deferredMeasurementCache={cache}
                                 >
-                                    {columns.map(({ label, dataKey }, index) => (
+                                    {columns.map(({ label, dataKey }) => (
                                         <Column
-                                            key={index}
+                                            key={label + dataKey}
                                             headerRenderer={headerRenderer}
                                             width={widths[dataKey] * total_width}
                                             label={label}

diff --git a/src/components/Dialogs/TradingView.js b/src/components/Dialogs/TradingView.js
@@ -28,6 +28,7 @@ function TradingViewComponent() {
                 id='iframe'
                 style={{ width: '100%', height: '100%', border: 'none' }}
                 src={config.trading_view_chart.url}
+                title={translate('Trading View')}
             />
         </div>
     );

diff --git a/src/components/Draggable/Draggable.jsx b/src/components/Draggable/Draggable.jsx
@@ -218,7 +218,9 @@ const Draggable = ({
                 <div
                     id='draggable-content__header'
                     className='draggable-content__header'
+                    role='button'
                     onMouseDown={e => handleMouseDown(e, MOVE)}
+                    onKeyDown={e => handleMouseDown(e, MOVE)}
                 >
                     <div className='draggable-content__header-title'>{header}</div>
                     <div>