Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Shayan/FEQ-911/github-actions-implementation #377

Conversation

shayan-deriv
Copy link
Contributor

@shayan-deriv shayan-deriv commented Nov 21, 2023

we are migrating from circle-ci to github actions.
I moved reusable parts to actions which are:

  • build
  • invalidate_npm_cache
  • npm_install_from_cache
  • publish_to_cf_pages_staging
  • publish_to_cf_pages_production
  • send_slack_notifications
  • setup_node
  • test
  • versioning

and also added two workflows :

  • release_staging
  • release_production
  • test

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-binary-bot ✅ Ready (Inspect) Visit Preview Dec 4, 2023 9:14am

@shayan-deriv shayan-deriv changed the title feat: added respected actions for circle-ci config Shayan/FEQ-911/github-actions-implementation Nov 24, 2023
@shayan-deriv shayan-deriv marked this pull request as ready for review November 24, 2023 06:10
.github/workflows/release_production.yml Outdated Show resolved Hide resolved
.github/workflows/release_production.yml Outdated Show resolved Hide resolved
.github/workflows/release_staging.yml Outdated Show resolved Hide resolved
.github/actions/setup_node/action.yml Show resolved Hide resolved
.github/workflows/release_production.yml Outdated Show resolved Hide resolved
@rupato-deriv
Copy link
Contributor

@ali-hosseini-deriv @shayan-deriv can you please check the node_version because last time when we were updating we had set it to 18 and the release was failing on staging so we had downgraded it to 16 because of cjs issue other than this all looks good 👍

@shayan-deriv
Copy link
Contributor Author

@ali-hosseini-deriv @shayan-deriv can you please check the node_version because last time when we were updating we had set it to 18 and the release was failing on staging so we had downgraded it to 16 because of cjs issue other than this all looks good 👍

Certainly, @rupato-deriv, we'll initially test it with version 18. If it encounters issues, we'll proceed with downgrading. Appreciate you bringing this to our attention! 👍

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit 309d1bb into deriv-com:master Dec 5, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants