maryia/BOT-2661/[App Separation] - Integrate query param logic to maintain auth context propagation #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-matskevich-deriv
requested review from
sandeep-deriv and
shafin-deriv
as code owners
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
shafin-deriv
reviewed
Jan 9, 2025
shafin-deriv
reviewed
Jan 9, 2025
shafin-deriv
reviewed
Jan 9, 2025
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
had a problem deploying
to
staging
GitHub Actions
Error
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
shafin-deriv
approved these changes
Jan 13, 2025
maryia-matskevich-deriv
force-pushed
the
maryia/BOT-2661
branch
from
ad553bf to
8a4d44d
Compare
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
shafin-deriv
approved these changes
Jan 15, 2025
…n user switches acc
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
…e it when user switches acc" This reverts commit 717ed1b.
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
had a problem deploying
to
staging
GitHub Actions
Error
maryia-matskevich-deriv
force-pushed
the
maryia/BOT-2661
branch
from
4343ff9 to
0e85ae0
Compare
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
staging
GitHub Actions
Inactive
|
Preview Link: https://maryia-BOT-2661.bot-65f.pages.dev
|
shafin-deriv
approved these changes
Jan 17, 2025
farabi-deriv
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[App Separation] - Integrate query param logic to maintain auth context propagation
Description: As a developer I want to implement a seamless auth flow. Meaning if the user clicks on DBot from app.deriv.com (Traders Hub/Dtrader) or any other app. It should propagate the selected account in the source tab to the newly opened tab.
Slack Conversation: https://deriv-group.slack.com/archives/C0871BRSJN4/p1735032395607869
Scenarios Document: https://docs.google.com/document/d/1Taq5ypnVG8KDVWTx5IdPJyWRaB3PCaNXa2yEVOMddNA/edit?usp=sharing
[DBOT] Account Switching Across Tabs
We need to standardise the behaviour of the platforms/tabs being opened from the TH and vice versa. Due to different standalone applications - Bots, P2P, Dtrader and TH the behaviour varies across different apps and clicks.
There are 3 ground rules to be taken care of :
No Back-syncing
Example : If an app, say DTrader, is opened with Demo account selected and user clicks on TH in a new tab and switches it to Real USD , then the previously opened DTrader will NOT be updated to Real USD.
2. Use the Source currency
Example : User is working on DTrader in demo account and then opens TH in new tab and switches it to Real USD. After this he opens Bots. Bots account should then be opened for Real USD.
3. Start a new tab/browser
If a user opens a new tab/browser and types in the URL (rather than opening it from the previously opened tab), then it should check the last opened state of the platform in the browser. If no previous state is found, it should be defaulted to Real FIAT account or Demo (if real is not created).
Example : If an app, say DTrader, is opened with Demo account selected and user clicks on TH in a new tab and switches it to Real USD. Then he opens a new tab and types in Bots URL. If he had previously accessed Bots with ETH currency, then the same should be opened now too.