Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup #15805

Conversation

amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Jun 26, 2024

Changes:

  • Created useTinValidations hook to fetch Tax related configurations for selected Tax residence
  • Moved form validation logic of Personal details, IDV form, Address details, Tax information to Yup schema
  • Added Account opening reason to Personal details section
  • Created re-usable Tax information section that can be used in Real account sign up and Personal details
  • Used @deriv-com/translation and dayjs libs
  • Added test cases to verify the functionality
  • Add a scroll and focus functionality to the required field in Personal details
  • Update @deriv/quill-icons lib version to v1.23.14
  • Added status page in Financial assessment that will be loaded if Employment status, Tax details and account opening reason are missing
  • Added redirection to Personal details
  • Added condition to highlight and focus field

likhith-deriv and others added 21 commits June 20, 2024 15:43
…o_real_account_signup' into likhith/TRAH-3480/emp-status-and-tin-in-account-settings
…us-and-tin-in-account-settings

chore: incorporated the new employment status and tin info
Amina/employment status form field
…loyment_status_and_tin_to_real_account_signup
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 4:48am

Copy link
Contributor

github-actions bot commented Jun 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15805](https://github.com/binary-com/deriv-app/pull/15805)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-trah3476-aminalikhithadde-b198ab.binary.sx?qa_server=red.derivws.com&app_id=32761
    - **Original**: https://deriv-app-git-fork-amina-deriv-trah3476-aminalikhithadde-b198ab.binary.sx
- **App ID**: `32761`

Copy link
Contributor

github-actions bot commented Jun 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-trah3476-aminalikhithadde-b198ab.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Oct 15, 2024
farrah-deriv
farrah-deriv previously approved these changes Oct 15, 2024
vinu-deriv
vinu-deriv previously approved these changes Oct 15, 2024
matin-deriv
matin-deriv previously approved these changes Oct 15, 2024
Copy link
Contributor

Generating Lighthouse report...

@likhith-deriv likhith-deriv merged commit 39f679f into deriv-com:master Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.