Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] aum / WALL-[4916 / 4925] / wallets-implement-default-jurisdiction-flows #16867

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Sep 17, 2024

Changes:

This is a PR to introduce the changes for default jurisdiction service part of the MT5 account creation flow.

Screenshots:

Pre-account creation

Screen.Recording.2024-10-01.at.4.34.26.PM.mov

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 11:10am

Copy link
Contributor

github-actions bot commented Sep 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16867](https://github.com/binary-com/deriv-app/pull/16867)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-4904wallets-implem-cfca3f.binary.sx?qa_server=red.derivws.com&app_id=31478
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-4904wallets-implem-cfca3f.binary.sx
- **App ID**: `31478`

Copy link
Contributor

github-actions bot commented Sep 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-4904wallets-implem-cfca3f.binary.sx/

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 53.567% (+0.06%) from 53.51%
when pulling 2b30ebc on aum-deriv:aum/WALL-4904/wallets-implement-default-jurisdiction-flows
into ee2c6e5 on binary-com:master.

…ion-post-account-creation-flow

[WALL] aum / WALL-4925 / default-jurisdiction-post-account-creation-flow
nijil-deriv
nijil-deriv previously approved these changes Oct 9, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Oct 9, 2024
jim-deriv
jim-deriv previously approved these changes Oct 9, 2024
…L-4904/wallets-implement-default-jurisdiction-flows
heorhi-deriv
heorhi-deriv previously approved these changes Oct 15, 2024
jim-deriv
jim-deriv previously approved these changes Oct 16, 2024
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants