Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitra/TRAH-4057/Seo improvement #16884

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mitra-deriv
Copy link
Contributor

@mitra-deriv mitra-deriv commented Sep 19, 2024

Changes:

change in meta title and description and text of cfd and option section

Screenshots:

Screenshot 2024-09-19 at 2 48 44 PM Screenshot 2024-09-19 at 2 49 03 PM Screenshot 2024-09-19 at 2 52 02 PM Screenshot 2024-09-19 at 2 51 41 PM Screenshot 2024-09-20 at 10 55 15 AM

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2024 8:23am

@mitra-deriv mitra-deriv changed the title chore: 🔍 seo improvement Mitra/TRAH-4057/Seo improvement Sep 19, 2024
@mitra-deriv mitra-deriv marked this pull request as draft September 19, 2024 03:09
Copy link
Contributor

github-actions bot commented Sep 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/16884](https://github.com/deriv-com/deriv-app/pull/16884)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mitra-deriv-trah-4057-seo-and-content-6a3c2d.binary.sx?qa_server=red.derivws.com&app_id=24045
    - **Original**: https://deriv-app-git-fork-mitra-deriv-trah-4057-seo-and-content-6a3c2d.binary.sx
- **App ID**: `24045`

Copy link
Contributor

github-actions bot commented Sep 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mitra-deriv-trah-4057-seo-and-content-6a3c2d.binary.sx/

@coveralls
Copy link

coveralls commented Sep 19, 2024

Coverage Status

coverage: 52.396% (+0.1%) from 52.262%
when pulling a6d2bc5 on mitra-deriv:trah-4057-seo-and-content-changes
into 04f4f8c on binary-com:master.

Copy link

sonarcloud bot commented Sep 20, 2024

@mitra-deriv mitra-deriv marked this pull request as ready for review September 20, 2024 02:56
habib-deriv
habib-deriv previously approved these changes Sep 20, 2024
shahzaib-deriv
shahzaib-deriv previously approved these changes Sep 20, 2024
@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11361384242

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 459 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.003%) to 53.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Constants/routes-config.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 80.6%
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
packages/wallets/src/features/accounts/modules/ManualService/components/DrivingLicenseUpload/DrivingLicenseUpload.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/ManualService/components/PassportUpload/PassportUpload.tsx 1 0.0%
packages/wallets/src/features/cashier/modules/WithdrawalCrypto/provider/WithdrawalCryptoProvider.tsx 1 51.37%
packages/wallets/src/features/accounts/modules/ManualService/components/IdentityCardUpload/IdentityCardUpload.tsx 1 0.0%
packages/appstore/src/components/routes/route-with-sub-routes.jsx 1 0.0%
packages/cashier/src/pages/account-transfer/account-transfer.tsx 1 98.18%
packages/stores/src/mockStore.ts 2 0.0%
packages/shared/src/utils/constants/contract.ts 2 81.25%
Totals Coverage Status
Change from base Build 11322810823: -0.003%
Covered Lines: 34716
Relevant Lines: 60257

💛 - Coveralls

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants