Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akmal / feat: barrier field improvements #17088

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

akmal-deriv
Copy link
Contributor

Changes:

This feature introduces improvements to the barrier field, enhancing usability and accuracy when users interact with barrier inputs.

  1. User Input Handling: Improve the handling of user inputs in the barrier field to prevent errors and allow more intuitive input methods.
  2. Validation Enhancements: Strengthen validation logic to ensure only valid values are accepted, reducing input errors and increasing reliability.
  3. User Experience: Refine the interface for barrier inputs to make the process more user-friendly and efficient.

These improvements aim to provide a smoother and more reliable experience when users interact with barrier fields.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 8:17am

Copy link
Contributor

github-actions bot commented Oct 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17088](https://github.com/deriv-com/deriv-app/pull/17088)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx
- **App ID**: `23835`

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx/

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11232881211

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 16 (87.5%) changed or added relevant lines in 2 files are covered.
  • 717 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.05%) to 53.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
packages/core/src/App/Containers/RealAccountSignup/choose-currency.js 1 18.18%
packages/stores/src/mockStore.ts 2 0.0%
packages/wallets/src/components/FlowProvider/index.ts 2 55.56%
packages/wallets/src/features/cashier/modules/DepositCrypto/DepositCrypto.tsx 5 28.57%
packages/core/src/App/Containers/RealAccountSignup/add-crypto-currency.jsx 13 11.11%
packages/core/src/App/Containers/RealAccountSignup/add-currency.jsx 18 6.56%
packages/core/src/App/Containers/RealAccountSignup/choose-currency.jsx 31 1.96%
packages/core/src/App/Containers/RealAccountSignup/real-account-signup.jsx 33 29.28%
packages/core/src/Stores/client-store.js 612 0.0%
Totals Coverage Status
Change from base Build 11209169403: 0.05%
Covered Lines: 34588
Relevant Lines: 60104

💛 - Coveralls

nijil-deriv
nijil-deriv previously approved these changes Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants