Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-4977 / Enable wallets translations for Français (FR) #17092

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Oct 7, 2024

Changes:

  • Add WALLETS_UNSUPPORTED_LANGUAGES constant to be used globally
  • Remove FR from language switcher exclusions
  • Fix UI issues for FR language in wallets

Screenshots:

image image image image

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 6:55am

@lubega-deriv lubega-deriv changed the title [WALL] Lubega / WALL-4977 / Enable wallets translations for Française (FR) [WALL] Lubega / WALL-4977 / Enable wallets translations for Français (FR) Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17092](https://github.com/deriv-com/deriv-app/pull/17092)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4977-wallets-french-249fc0.binary.sx?qa_server=red.derivws.com&app_id=32869
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4977-wallets-french-249fc0.binary.sx
- **App ID**: `32869`

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-4977-wallets-french-249fc0.binary.sx/

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11379284971

Details

  • 46 of 53 (86.79%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 53.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Components/Layout/Header/Components/ToggleMenu/mobile-language-menu.tsx 0 1 0.0%
packages/core/src/App/Containers/SettingsModal/settings-language.jsx 0 1 0.0%
packages/wallets/src/features/cashier/screens/DepositErrorScreen/DepositErrorScreen.tsx 6 7 85.71%
packages/wallets/src/features/cashier/screens/WithdrawalErrorScreen/WithdrawalErrorScreen.tsx 6 7 85.71%
packages/wallets/src/features/cfd/screens/Jurisdiction/JurisdictionTncSection/JurisdictionTncSection.tsx 0 1 0.0%
packages/core/src/App/AppContent.tsx 0 2 0.0%
Totals Coverage Status
Change from base Build 11379143622: 0.02%
Covered Lines: 34914
Relevant Lines: 60484

💛 - Coveralls

heorhi-deriv
heorhi-deriv previously approved these changes Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants