Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH #17101

Conversation

suisin-deriv
Copy link
Contributor

Changes:

fixed user coming from personal detail when verified not redirecting to TradersHub

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2024 6:28am

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11359836055

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 510 unchanged lines in 39 files lost coverage.
  • Overall coverage increased (+0.07%) to 53.604%

Files with Coverage Reduction New Missed Lines %
packages/account/src/Sections/Profile/PhoneVerification/verification-link-expired-modal.tsx 1 86.96%
packages/stores/src/mockStore.ts 1 0.0%
packages/account/src/Sections/Profile/PhoneVerification/otp-verification.tsx 1 84.35%
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 1 90.65%
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 80.6%
packages/cashier/src/app-content.tsx 1 0.0%
packages/wallets/src/features/cfd/screens/EnterPassword/EnterPassword.tsx 1 83.13%
packages/trader/src/AppV2/Components/TradeParameters/Duration/wheelpicker.tsx 1 85.71%
packages/wallets/src/features/accounts/modules/ManualService/components/DrivingLicenseUpload/DrivingLicenseUpload.tsx 1 0.0%
packages/api-v2/src/ws-client/subscriptions-manager.ts 1 91.89%
Totals Coverage Status
Change from base Build 11214862356: 0.07%
Covered Lines: 34715
Relevant Lines: 60255

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Oct 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17101](https://github.com/deriv-com/deriv-app/pull/17101)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1539fixrouting-b728ed.binary.sx?qa_server=red.derivws.com&app_id=31482
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1539fixrouting-b728ed.binary.sx
- **App ID**: `31482`

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm1539fixrouting-b728ed.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Oct 8, 2024
amina-deriv
amina-deriv previously approved these changes Oct 8, 2024
Copy link
Contributor

Generating Lighthouse report...

@likhith-deriv likhith-deriv merged commit c6e965d into deriv-com:master Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants