Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT} feat: redirection to standalone from monorepo, under feature flag #17152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wojciech-deriv
Copy link
Contributor

DRAFT: initial implementation of redirection from monorepo to standalone under feature flag

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 10, 2024 2:46pm

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Oct 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17152](https://github.com/deriv-com/deriv-app/pull/17152)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-feature-redirect-to-standalone.binary.sx?qa_server=red.derivws.com&app_id=24101
    - **Original**: https://deriv-app-git-feature-redirect-to-standalone.binary.sx
- **App ID**: `24101`

Copy link
Contributor

github-actions bot commented Oct 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-feature-redirect-to-standalone.binary.sx/

Copy link
Contributor

package old new diff pct change
account 300 KB 300 KB 0 B 0% 🟢
appstore 531 KB 531 KB +14 B +0.0% 🟢
bot-web-ui 688 KB 688 KB +13 B +0.0% 🟢
cashier 622 KB 622 KB +15 B +0.0% 🟢
cfd 134 KB 134 KB 0 B 0% 🟢
core 6.9 MB 6.9 MB +191 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +11 B +0.0% 🟢
trader 583 KB 583 KB +12 B +0.0% 🟢
wallets 1.0 MB 1.0 MB 0 B 0% 🟢

Copy link
Contributor

package old new diff pct change
account 300 KB 300 KB 0 B 0% 🟢
appstore 531 KB 531 KB +13 B +0.0% 🟢
bot-web-ui 688 KB 688 KB +17 B +0.0% 🟢
cashier 622 KB 622 KB +15 B +0.0% 🟢
cfd 134 KB 134 KB 0 B 0% 🟢
core 6.9 MB 6.9 MB +196 B +0.0% 🟢
p2p 1.0 MB 1.0 MB +4 B +0.0% 🟢
reports 59 KB 59 KB +17 B +0.0% 🟢
trader 583 KB 583 KB +23 B +0.0% 🟢
wallets 1.0 MB 1.0 MB +1 B +0.0% 🟢

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11275613155

Details

  • 3 of 12 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 53.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/utils/config/config.ts 1 2 50.0%
packages/shared/src/utils/helpers/dtrader-v2-helpers.ts 1 2 50.0%
packages/core/src/App/Constants/routes-config.js 1 8 12.5%
Totals Coverage Status
Change from base Build 11272857189: -0.005%
Covered Lines: 34761
Relevant Lines: 60339

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants