Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA-2181 redirection to standalone from monorepo, under feature flag #17152

Closed
wants to merge 4 commits into from

Conversation

azmib-developer
Copy link
Contributor

@azmib-developer azmib-developer commented Oct 10, 2024

Redirect from monorepo to standalone, under feature flag.
Suggestions welcome, I'm not that happy with the solution, but thats best idea I have at the moment.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 22, 2024 1:42pm

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Oct 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17152](https://github.com/deriv-com/deriv-app/pull/17152)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-feature-redirect-to-standalone.binary.sx?qa_server=red.derivws.com&app_id=24101
    - **Original**: https://deriv-app-git-feature-redirect-to-standalone.binary.sx
- **App ID**: `24101`

Copy link
Contributor

github-actions bot commented Oct 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-feature-redirect-to-standalone.binary.sx/

Copy link
Contributor

package old new diff pct change
account 300 KB 300 KB 0 B 0% 🟢
appstore 531 KB 531 KB +14 B +0.0% 🟢
bot-web-ui 688 KB 688 KB +13 B +0.0% 🟢
cashier 622 KB 622 KB +15 B +0.0% 🟢
cfd 134 KB 134 KB 0 B 0% 🟢
core 6.9 MB 6.9 MB +191 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +11 B +0.0% 🟢
trader 583 KB 583 KB +12 B +0.0% 🟢
wallets 1.0 MB 1.0 MB 0 B 0% 🟢

Copy link
Contributor

package old new diff pct change
account 300 KB 300 KB 0 B 0% 🟢
appstore 531 KB 531 KB +13 B +0.0% 🟢
bot-web-ui 688 KB 688 KB +17 B +0.0% 🟢
cashier 622 KB 622 KB +15 B +0.0% 🟢
cfd 134 KB 134 KB 0 B 0% 🟢
core 6.9 MB 6.9 MB +196 B +0.0% 🟢
p2p 1.0 MB 1.0 MB +4 B +0.0% 🟢
reports 59 KB 59 KB +17 B +0.0% 🟢
trader 583 KB 583 KB +23 B +0.0% 🟢
wallets 1.0 MB 1.0 MB +1 B +0.0% 🟢

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11461125851

Details

  • 3 of 12 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 53.797%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/utils/config/config.ts 1 2 50.0%
packages/shared/src/utils/helpers/dtrader-v2-helpers.ts 1 2 50.0%
packages/core/src/App/Constants/routes-config.js 1 8 12.5%
Totals Coverage Status
Change from base Build 11461023064: -0.006%
Covered Lines: 35157
Relevant Lines: 60779

💛 - Coveralls

@azmib-developer azmib-developer changed the title [DRAFT} feat: redirection to standalone from monorepo, under feature flag DTRA-2181 wojtek feat: redirection to standalone from monorepo, under feature flag Oct 22, 2024
@azmib-developer azmib-developer changed the title DTRA-2181 wojtek feat: redirection to standalone from monorepo, under feature flag DTRA-2181 redirection to standalone from monorepo, under feature flag Oct 22, 2024
Copy link
Contributor

package old new diff pct change
account 299 KB 299 KB 0 B 0% 🟢
appstore 487 KB 487 KB +12 B +0.0% 🟢
bot-web-ui 681 KB 681 KB +15 B +0.0% 🟢
cashier 575 KB 575 KB +10 B +0.0% 🟢
cfd 134 KB 134 KB 0 B 0% 🟢
core 6.9 MB 6.9 MB +308 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +18 B +0.0% 🟢
trader 587 KB 587 KB +17 B +0.0% 🟢
wallets 1.1 MB 1.1 MB +11 KB +1.0% 🟡

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Generating Lighthouse report...

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 22, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants