Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA]feat: added growthbook feature flag for dtrader-v2 #17160

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 14, 2024 0:48am

Copy link
Contributor

github-actions bot commented Oct 11, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17160](https://github.com/deriv-com/deriv-app/pull/17160)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-dtra-1932growthbook-f-ec3c5c.binary.sx?qa_server=red.derivws.com&app_id=24035
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-dtra-1932growthbook-f-ec3c5c.binary.sx
- **App ID**: `24035`

Copy link
Contributor

github-actions bot commented Oct 11, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-dtra-1932growthbook-f-ec3c5c.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11287418770

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 53.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/index.tsx 0 14 0.0%
Totals Coverage Status
Change from base Build 11286268619: -0.003%
Covered Lines: 34757
Relevant Lines: 60331

💛 - Coveralls


const App = ({ passthrough }: Apptypes) => {
const [dtrader_v2_enabled] = useGrowthbookGetFeatureValue({
Copy link
Contributor

@kate-deriv kate-deriv Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will new value from useGrowthbookGetFeatureValue hook triggers App component re-rendering? In case of 'yes' do we need then part with setting state in useEffect?
I mean could you please check, will it work without

     const [dtrader_v2_enabled_gb, setDTraderV2EnabledGb] = React.useState(false);

    React.useEffect(() => {
        setDTraderV2EnabledGb(Boolean(dtrader_v2_enabled));
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [dtrader_v2_enabled, Analytics?.getInstances?.().ab?.GrowthBook.getFeatures()]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants