[DTRA]Ahmad/ Hour Picker and Other fixes #17168
+240
−112
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import { WheelPickerContainer } from '@deriv-com/quill-ui'; | ||
| import React, { useState, useEffect } from 'react'; | ||
|
|
||
| type TimeOption = { | ||
| label: string; | ||
| value: number; | ||
| }; | ||
|
|
||
| const HourPicker = ({ | ||
| setWheelPickerValue, | ||
| selected_hour, | ||
| selected_time, | ||
| duration_min_max, | ||
| }: { | ||
| setWheelPickerValue: (index: number, value: string | number) => void; | ||
| selected_hour: number[]; | ||
| selected_time: number[]; | ||
| duration_min_max: Record<string, { min: number; max: number }>; | ||
| }) => { | ||
| const [hours, setHours] = useState<TimeOption[]>([]); | ||
| const [minutes, setMinutes] = useState<TimeOption[]>([]); | ||
|
|
||
| useEffect(() => { | ||
| const min_seconds = Math.max(duration_min_max.intraday.min, 3600); | ||
| const max_seconds = duration_min_max.intraday.max; | ||
|
|
||
| const min_hours = Math.max(1, Math.ceil(min_seconds / 3600)); | ||
| const max_hours = Math.floor(max_seconds / 3600); | ||
|
|
||
| const new_hours = Array.from({ length: max_hours - min_hours + 1 }, (_, i) => ({ | ||
| label: `${i + min_hours} h`, | ||
| value: i + min_hours, | ||
| })); | ||
| setHours(new_hours); | ||
|
|
||
| update_minutes(selected_hour[0] || min_hours, min_seconds, max_seconds); | ||
| }, [duration_min_max, selected_hour]); | ||
|
|
||
| const update_minutes = (selected_hour: number, min_seconds: number, max_seconds: number) => { | ||
| let min_minutes = 0; | ||
| let max_minutes = 59; | ||
|
|
||
| if (selected_hour === Math.ceil(min_seconds / 3600)) { | ||
| min_minutes = Math.ceil((min_seconds % 3600) / 60); | ||
| } | ||
|
|
||
| if (selected_hour === Math.floor(max_seconds / 3600)) { | ||
| max_minutes = Math.floor((max_seconds % 3600) / 60); | ||
| } | ||
|
|
||
| if (min_minutes > 0 && selected_hour * 3600 >= min_seconds) { | ||
| min_minutes = 0; | ||
| } | ||
|
|
||
| const new_minutes = Array.from({ length: max_minutes - min_minutes + 1 }, (_, i) => ({ | ||
| label: `${i + min_minutes} min`, | ||
| value: i + min_minutes, | ||
| })); | ||
| setMinutes(new_minutes); | ||
| }; | ||
|
|
||
| const handle_value_change = (index: number, value: string | number) => { | ||
| setWheelPickerValue(index, value); | ||
| if (index === 0) { | ||
| update_minutes(Number(value), duration_min_max.intraday.min, duration_min_max.intraday.max); | ||
| } | ||
| }; | ||
|
|
||
| const getDefaultValue = (options: TimeOption[], selected_value: number) => { | ||
| const option = options.find(opt => opt.value === selected_value); | ||
| return option ? option.label : options[0]?.label || '1 h'; | ||
| }; | ||
|
|
||
| return ( | ||
| <WheelPickerContainer | ||
| data={[hours, minutes]} | ||
| defaultValue={[getDefaultValue(hours, selected_hour[0]), getDefaultValue(minutes, selected_time[1])]} | ||
| containerHeight={'268px'} | ||
ahmadtaimoor-deriv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| inputValues={[selected_hour[0] || hours[0]?.value, selected_time[1] || minutes[0]?.value]} | ||
| setInputValues={handle_value_change} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default HourPicker; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in wallets, we recently removed moment due to its size,
as much as I like moment (and I personally still use it in non-client-facing projects), I'm wondering if it shouldn't be deprecated and not being added anymore, in favour of something more modern and more treeshakeable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In V2 , we are not actually using moment . The
server_timeis handled in store primarily used in V1 and is handled via moment . So in order to utilize that I had to use the moment .