-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WALL] george / WALL-5028 / Lazy Load "react-joyride" library with wallet onboarding tour guide code #17178
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
Pull Request Test Coverage Report for Build 11346462576Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-ll-tourguide.binary.sx/ |
packages/core/src/App/Containers/Layout/header/traders-hub-onboarding.tsx
Show resolved
Hide resolved
e3620ee
to
2b5033f
Compare
4f0c42f
4f0c42f
to
ad40466
Compare
⏳ Generating Lighthouse report... |
Changes:
Currently, we're loading the Joyride library for the onboarding tour guide during the initial render of the main wallets page. However, since this tour guide is typically only shown once, there's no need to fetch the react-joyride library and its associated code every time the user lands on the main page. To optimize performance, we’re now applying Lazy Loading to the
WalletTourGuide
component, reducing the initial load size for the user.Screenshots: