Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farabi/fix--remove-integration-package #17201

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Removed integration package that got added back during conflict resolving.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2024 4:18am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17201](https://github.com/deriv-com/deriv-app/pull/17201)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-fix-remove-integr-9cd9a0.binary.sx?qa_server=red.derivws.com&app_id=24087
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-fix-remove-integr-9cd9a0.binary.sx
- **App ID**: `24087`

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11358569732

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 53.601%

Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 11348620484: -0.003%
Covered Lines: 34713
Relevant Lines: 60254

💛 - Coveralls

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 35
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-fix-remove-integr-9cd9a0.binary.sx/

@farabi-deriv farabi-deriv merged commit cd36909 into deriv-com:master Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants