Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM-1431] Suisin/chore: update new design changes on withdrawal limits #17217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Oct 16, 2024

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 6:20am

Copy link
Contributor

github-actions bot commented Oct 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17217](https://github.com/deriv-com/deriv-app/pull/17217)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1431totalwithd-1d50c9.binary.sx?qa_server=red.derivws.com&app_id=24064
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1431totalwithd-1d50c9.binary.sx
- **App ID**: `24064`

Copy link
Contributor

github-actions bot commented Oct 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm1431totalwithd-1d50c9.binary.sx/

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11379149473

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 3 files are covered.
  • 809 unchanged lines in 30 files lost coverage.
  • Overall coverage increased (+0.05%) to 53.675%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/utils/constants/withdrawal-limits-details.tsx 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
packages/bot-web-ui/src/pages/dashboard/announcements/config.tsx 1 80.0%
packages/account/src/Sections/Verification/ProofOfIdentity/onfido.jsx 1 5.56%
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx 1 95.38%
packages/account/src/Components/personal-details/personal-details.tsx 1 93.08%
packages/account/src/Sections/Profile/PhoneVerification/session-timeout-modal.tsx 1 94.44%
packages/core/src/App/Containers/RealAccountSignup/account-wizard-form.js 1 0.0%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
packages/stores/src/mockStore.ts 2 0.0%
packages/account/src/Components/form-field-info/index.ts 2 0.0%
Totals Coverage Status
Change from base Build 11363997688: 0.05%
Covered Lines: 34908
Relevant Lines: 60485

💛 - Coveralls

fasihali-deriv
fasihali-deriv previously approved these changes Oct 17, 2024
fasihali-deriv
fasihali-deriv previously approved these changes Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants