Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aswathy/fix: updated the babel packages and security issue of babel-traverse #17225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Oct 17, 2024

Changes:

Updated all the deprecated babel plugins and the babel-traverse that was causing the security issues

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 7:39am

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11380563543

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 47 files lost coverage.
  • Overall coverage increased (+0.02%) to 53.695%

Files with Coverage Reduction New Missed Lines %
packages/wallets/src/features/cfd/flows/ClientVerification/components/ResubmissionSuccessMessage/ResubmissionSuccessMessage.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/DocumentService/components/VerifyPersonalDetails/components/VerifyPersonalDetailsErrorMessage/VerifyPersonalDetailsErrorMessage.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/TaxInformation/components/NeedHelpMessage/NeedHelpMessage.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/TaxInformation/hooks/useTaxInformation.ts 1 0.0%
packages/wallets/src/features/accounts/modules/ManualService/components/ManualUploadErrorMessage/ManualUploadErrorMessage.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/ManualService/components/DocumentSelection/components/DocumentSelectionCard/DocumentSelectionCard.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/ManualService/ManualService.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/Poa/components/CommonMistakesExamples/CommonMistakesExamples.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/ManualService/components/DocumentRules/components/DocumentRuleTile/DocumentRuleTile.tsx 1 0.0%
packages/wallets/src/features/accounts/modules/Poa/hooks/usePoa.ts 1 0.0%
Totals Coverage Status
Change from base Build 11378556860: 0.02%
Covered Lines: 34771
Relevant Lines: 60313

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Oct 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17225](https://github.com/deriv-com/deriv-app/pull/17225)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-babel-traverse-issue-fix.binary.sx?qa_server=red.derivws.com&app_id=24104
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-babel-traverse-issue-fix.binary.sx
- **App ID**: `24104`

Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-babel-traverse-issue-fix.binary.sx/

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants