Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA-2055 +1 / Kate / [DTrader-V2] Trade page scrolling issue #17230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Oct 17, 2024

Changes:

  • Update Quill UI library version
  • Wrapped all closing functions with useCallback as in Quill they are in array with dependencies of useEffect--> causing rerendering
  • Added prop from Quill ActionSheet Root fro bluring

Screenshots:

Screen.Recording.2024-10-17.at.10.06.50.AM.mov

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 8:19am

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11380497048

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 20 of 21 (95.24%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 53.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Utils/trade-params-utils.tsx 1 87.88%
Totals Coverage Status
Change from base Build 11379143622: 0.003%
Covered Lines: 34893
Relevant Lines: 60465

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Oct 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17230](https://github.com/deriv-com/deriv-app/pull/17230)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-2055quilladdblur.binary.sx?qa_server=red.derivws.com&app_id=23881
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-2055quilladdblur.binary.sx
- **App ID**: `23881`

Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-2055quilladdblur.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants