Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBREL] WEBREL-3246-Not-able-to-proceed-account-creation-for-IDV?expand=1 #17239

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • Cherry-pick fix from rc_V20241015_0 branch to master.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:43pm

@heorhi-deriv heorhi-deriv merged commit 3fecfc4 into deriv-com:master Oct 17, 2024
5 of 6 checks passed
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17239](https://github.com/deriv-com/deriv-app/pull/17239)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-webrel-3246-not-able-to-6164f0.binary.sx?qa_server=red.derivws.com&app_id=24087
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-webrel-3246-not-able-to-6164f0.binary.sx
- **App ID**: `24087`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-webrel-3246-not-able-to-6164f0.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11387927482

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 53.67%

Files with Coverage Reduction New Missed Lines %
packages/account/src/Configs/kyc-validation-config.ts 1 82.93%
packages/account/src/Helpers/utils.tsx 1 76.24%
Totals Coverage Status
Change from base Build 11383013039: -0.009%
Covered Lines: 34896
Relevant Lines: 60468

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants