-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline OS Redirect logic and enhance cookie management for accounts redirection #17877
Streamline OS Redirect logic and enhance cookie management for accounts redirection #17877
Conversation
* feat: test redirection * feat: test redirection * Amina/redirection test (deriv-com#17606) * feat: test redirection * feat: test redirection * fix: query param * fix: sidebar * fix: sidebar * fix: linting --no-verify * fix: button * fix: button
… config/redirects-from-os-to-deriv-app
…ects-from-os-to-deriv-app
…b.com/shahzaib-deriv/deriv-app into config/redirects-from-os-to-deriv-app
… config/redirects-from-os-to-deriv-app
* Amina/redirection test (deriv-com#17643) * feat: test redirection * feat: test redirection * Amina/redirection test (deriv-com#17606) * feat: test redirection * feat: test redirection * fix: query param * fix: sidebar * fix: sidebar * fix: linting --no-verify * fix: button * fix: button * feat: add OSRedirect component and update routes config * chore: wait for logged in state before redirection --------- Co-authored-by: amina-deriv <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-config-redirects-from-aea58d.binary.sx/ |
… config/redirects-from-os-to-deriv-app
…b.com/shahzaib-deriv/deriv-app into config/redirects-from-os-to-deriv-app
- Remove direct redirection to hub.deriv.com from page-overlay - Add is_from_tradershub_os computed property in common store - Add platform detection utility for traders hub OS - Update types and components to handle traders hub OS platform - Clean up imports organization in page-overlay component
Pull Request Test Coverage Report for Build 12478155101Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
⏳ Generating Lighthouse report... |
This PR adds the OSRedirect component to improve its functionality and maintainability with the following changes:
Changes
routes_list
for better maintainabilityTechnical Details
active_wallet_loginid
cookiedtrader_routes
andaccounts_routes
into a singleroutes_list
/financial-assessment
and/trading-assessment
routes