-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add pull request template (#271)
- Loading branch information
1 parent
5727c3d
commit 8397dea
Showing
1 changed file
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
<!-- Please refer to this [guide](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) for any confusion while creating the PR --> | ||
|
||
**Clickup link:** <!-- Add your clickup link here, Remove this line if this PR is not for a task --> | ||
**Fixes issue:** #<!-- Issue number here, Remove this line if this PR isn't related to any issue --> | ||
|
||
This PR contains the following changes: | ||
|
||
<!-- Provide a description or list of changes --> | ||
|
||
- [ ] ✨ New feature (non-breaking change which adds functionality) | ||
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue) | ||
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change) | ||
- [ ] 🧹 Code refactor | ||
- [ ] ✅ Build configuration change | ||
- [ ] 📝 Documentation | ||
- [ ] 🗑️ Chore | ||
|
||
### Developers Note (Optional) | ||
|
||
<!-- REMOVE THIS SECTION IF IT IS NOT NEEDED.> | ||
<!-- Add the reason of making changes in this approach so that it will be helpful to reviewers while reviewing it. --> | ||
|
||
## Pre-launch Checklist (For PR creator) | ||
|
||
As a creator of this PR: | ||
|
||
<!-- Put an `x` in all the boxes that apply ([x]) --> | ||
|
||
- [ ] ✍️ I have included clickup id and package/app_name in the PR title. <!-- Find the guide [here](https://github.com/regentmarkets/flutter-deriv-packages/blob/master/.github/GIT_RULES.md#pr-rules) --> | ||
- [ ] 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.). | ||
- [ ] ⚒️ I have fixed any errors/warnings shown by the analyzer/linter. | ||
- [ ] 📝 I have added documentation, comments and logging wherever required. | ||
- [ ] 🧪 I have added necessary tests for these changes. | ||
- [ ] 🔎 I have ensured all existing tests are passing. | ||
|
||
## Reviewers | ||
|
||
<!-- Tag the reviewers of this PR --> | ||
|
||
## Pre-launch Checklist (For Reviewers) | ||
|
||
As a reviewer I ensure that: | ||
|
||
- [ ] ✴️ This PR follows the standard PR template. | ||
- [ ] 🪩 The information in this PR properly reflects the code changes. | ||
- [ ] 🧪 All the necessary tests for this PR's are passing. | ||
|
||
## Pre-launch Checklist (For QA) | ||
|
||
- [ ] 👌 It passes the acceptance criteria. | ||
|
||
## Pre-launch Checklist (For Maintainer) | ||
|
||
- [ ] [MAINTAINER_NAME] I make sure this PR fulfills its purpose. |