Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ramin/merge dev into master #277

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Ramin/merge dev into master #277

merged 4 commits into from
Nov 29, 2023

Conversation

ramin-deriv
Copy link
Contributor

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

ramin-deriv and others added 4 commits November 8, 2023 16:46
@ramin-deriv
update main.dart file (#269)
3e01bb1
@sahani-deriv
deps: fix dependency issue (#270)
ccc4518
@sahani-deriv
ci: integrate github actions (#272)
5727c3d 
* ci: integrate github actions

ci: fix analyze failure in info

ci: enable caching

fix: build issue

temp: fix dependency for test run

temp: clean pub cache

deps: fix

fix: deriv packages dependency

test-pr

feat: integrate GH

test: check git actions

* deps: revert dependency change

* chore: rename actions

* chore: rename ssh key

* fix: fail build on dart format changed

* feat: add concurrency

* chore: delete circle ci
@ahrar-deriv
chore: add pull request template (#271)
8397dea
@ramin-deriv ramin-deriv merged commit 381b154 into deriv-com:master Nov 29, 2023
0 of 3 checks passed
@ramin-deriv ramin-deriv deleted the ramin/merge_dev_into_master branch November 29, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramin-deriv @sahani-deriv @ahrar-deriv