Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ramin/Update_dev_with_fe_changes #287

Closed
wants to merge 29 commits into from
Closed

Ramin/Update_dev_with_fe_changes #287

wants to merge 29 commits into from

Conversation

ramin-deriv
Copy link
Contributor

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@ramin-deriv ramin-deriv marked this pull request as ready for review December 25, 2023 03:25
sahani-deriv and others added 28 commits March 7, 2024 17:52
@sahani-deriv @ramin-deriv
sahani/migrate_flutter_to_version_3_10 (#225)
a22c9f0 
- migrate flutter to version 3.10.0
@hamed-rezaee @ramin-deriv
hamed/update_dependencies (#227)
a4e0f4d 
- update dependencies
@maryia-deriv @ramin-deriv
Maryia/78669/add drawing tools list (#195)
fe78002 
- setup drawing tools config
@ramin-deriv
bahar/82930/Add hollow chart type (#202)
c3b849e 
- Add hollow chart type
@ramin-deriv
bahar/82932/feat: add_ohlc_chart_type (#204)
8683d03
@ramin-deriv
maryia|bahar/78755/Add vertical and line drawing tool (#207)
2a3b8dc
@ramin-deriv
bahar/82785/Make drawings draggable (#224)
1389826 
* feat: make_drawings_draggable

* line_changes_added_before_cleanup

* cleanup

* extract_drawing_tool_chart

* fixed_crosshair_issue

* fix_long_press_issue

* make_drawing_class_abstract

* fix_review_issues

* added_enum_for_darwing_parts

* fix_review_comments

* fix_review_pointed_out_issues

* fix_comments

* add initial value for draggable edge point and remove extra inputs

* add vector.zero

* drawing_selection_added

* review_comments

* handle unfinished drawings

* fix_review_comments

* fix_json_autogenerated_files_issue
@ramin-deriv
bahar/feat: add_continuous_drawing_tool (#229)
3557384 
- Add continuous drawing tool
@ahmadtaimoor-deriv @ramin-deriv
Ahmad/Add trend drawing tool (#236)
216cc35 
- add trend drawing tool
@ramin-deriv
bahar/Add ray drawing tool (#235)
42951e5 
- add ray drawing tool
@ramin-deriv
bahar/Add fibfan drawing tool (#238)
dcae40a 
* feat: add_continuous_drawing_tool

* a little refactor

* cleanup

* refactor

* refactor the code

* add comment

* fix_review_comments

* extracting drawing tools logic from deriv chart

* fix the issue with dragging line edge points

* feat: add_fibfan_drawing_tool

* fix_draggable_edge_points_bug

* fix_draggable_edge_points_bug

* add_typedef_for_onadddrawing

* add_labels

* fix_issue

* fix_label_issue

* fix review comments

* fix review comments

* constants added

* fix issue with markers and shadow overlapping
@ramin-deriv
bahar/Add channel drawing tool (#237)
55e6d83 
- add channel drawing
@ahmadtaimoor-deriv @ramin-deriv
Ahmad/Add rectangle drawing (#232)
9dd2500 
- add rectangle drawing tool
@ahmadtaimoor-deriv @ramin-deriv
Ahmad /Add Horizontal Drawing Tool (#239)
f1516f3 
- add Horizontal Drawing tool
@ahmadtaimoor-deriv @ramin-deriv
Drawing tool merge fix (#249)
14d0abe 
* Ahmad/78749/Drawing tool- Horizontal

* Ahmad/78749/Drawing tool- Horizontal

* adding constant file

* yCood, _startingYPoint to quote,_startingQuote

* Adding label

* drawing Label class

* PR fixes

* testing branch

* removing comment

* PR Fixes

* Adding descriptive comment

* merge commit fix

* sequence of drawing tools in dialog

* label design fix

* merge fixes reopened

---------

Co-authored-by: Ahmad Taimoor <ahmadtaimoor@Ahmad-Taimoor-Suddles-MacBook-Pro-C02YN1TNJGH6.local>
@ramin-deriv
ramin/drawing_tools_performance_improvement (#246)
091d00a 
- drawing tools performance improvement
@ramin-deriv
fix market_selector_test.dart (#251)
56414d0
@balakrishna-deriv @ramin-deriv
Bala/Add web support (#208)
ec840ad 
- add web support
@ramin-deriv
bahar/Restore drawings (#242)
7d47595 
- add restore drawing feature
@ahmadtaimoor-deriv @ramin-deriv
Feat drawingtool integration (#247)
12c926f 
- drawing tools integration
@ramin-deriv
add a todo comment (#254)
c2ec0df
@balakrishna-deriv @ahmadtaimoor-deriv @ramin-deriv
Add combinePaths function & Performance improvement (#245)
ea8c278 
* feat: expose chart scaling

* feat: web adapter init

* chore: add models

* chore: fix lint issues

* chore: fix issue with map

* chore: fix map issue 2

* chore: update light theme colors

* feat: integrate multiplier barrier and shade

* feat: draggable barrier - relative and absolute

* feat: add web markers support

* feat: contract replay painter

* chore: add interops and callbacks

* chore: add util functions

* chore: add flag to hide crosshair

* chore: active marker drawing and update end icon

* Revert "feat: draggable barrier - relative and absolute"

This reverts commit 0ecba93.

* Revert "feat: integrate multiplier barrier and shade"

This reverts commit 49fa8a8.

* chore: fix instance issue

* fix: marker drawings

* refactor: start and end markers

* chore: add digit contract toggle

* refactor: tick points

* chore: fix quote grid initial render

* refactor: chart options

* add indicatorsRepo

* fix: order of repaint check

* chore: add id to indicators

* fix: ambiguous import issue

* chore: indicator integration

* refactor: add dart interop

* refactor: interop

* chore: remove web_adapter

* chore: show y-axis on indicators

* chore: remove unused import

* chore: add id to series

* feat: add bottom chart options

* chore: add crosshair callbacks

* chore: update dataFitMode

* chore: show icons if the prop is null

* refactor: remove unused code

* refactor: marker and crosshair

* fix: series type comparison

* fix: review comments

* refactor: remove painters related to web charts

* refactor: remove web marker paintings

* refactor: remove web related props

* chore: remove bool compare

* chore: add repository interface

* refactor: modify to interface

* add maxCurrentTickOffset config

* chore: remove id

* refactor: indicator repository

* chore: add bar style to gator

* chore: remove id from indicator config

* chore: generate g.dart files

* chore: macd add configs

* chore: add roc line style

* chore: add linestyle to StochasticOscillator

* chore: add linestyle to william r indicator

* chore: add color config to aroon indicator

* chore: add ADX configs

* chore: add ichimoku line styles

* chore: add bollinger line styles

* chore: add linestyle to ma env

* chore: add line style to alligator

* chore: remove id form add on

* chore: update bollinger bands colors

* refactor: remove marker area changes

* refactor: update to _getIndicatorSeries

* chore: add createAddOn callback

* chore: add title to the indicator

* chore: sort out review comments

* feat: add expand/collapse and move icons

* fix: null exception on delete indicator

* chore: remove unnecessary non-nullable type

* fix: pinch-to-zoom

* fix: add missing title to dpo

* chore: hide move icons when expanded

* fix: builds the widget after animation to render the y-axis correctly

* fix: pinch to zoom on mobile

* refactor: make functions in repository consistent

* chore: add linestyle to dpo indicator

* chore: update crosshair doc

* refactor: update to repo interface

* Bug fixes 1 (#12)

* chore: exposes scrollBy function

* chore: customize msPerPx and leftMargin

* chore: add second intervals

* chore: configuration to change rainbow colors

* Ahmad/78749/Drawing tool- Horizontal

* Ahmad/78749/Drawing tool- Horizontal

* adding constant file

* removing the horizontal tool functionality

* chore: expore series and indicator configs

* chore: make line series public inorder to access it from outside the chart

* chore: expose indicator series and fix williams oscillator series

* chore: expose indicator series

* fix: bottom title for dark theme

* chore: expose make series and configs

* fix: wrap expandedIndex in setState

* fix: channel fill for bollinger and donchian

* fix: check shouldUpdate for series to draw it when the config is changed

* chore: add shouldRepaint override for MA Series

* chore: fix bottom chart title color

* chore: modify candle colors for light theme

* fix: theme text

* chore: fix theme text

* fix: html mode barrier painting

* fix for endIndex

* removing stashed data

* day seperator

* revert zigzag fix

* chore: remove candle style here

* changing color to theme color

* formatting

* chore: add showLastIndicator config

* chore: add pipsize for bottom indicators

* chore: add last indicator alligator

* chore: add pipsize to indicators #2

* chore: add pipsize and lastindicatorstyle to idnicators #3

* chore: add pipsize and lastindicatorstyle to indicators #4

* chore: add last indicator style for overlay indicators

* chore: add fcb configs

* refactor: timestamp variable

* chore: add adx shading

* chore: fix y-axis labels

* Ahmad/Adx Indicator fix (#11)

* smi fix

* adx and gator

* chore: add container to get height and width from size

* chore: revert startWithDataFitMode

* chore: add showDataFitButton and animation props

* chore: add padding and margin to props

* revert: vertical padding

* chore: expose verticalPaddingFraction

* fix: isLive issue

* chore: revert changes

* chore: customize minIntervalWidth

* chore: remove showLoadingAnimationForHistoricalData customization.

* chore: move assets to different package

* refactor: controller fn

* chore: get current msPerPx

* Revert "chore: move assets to different package"

This reverts commit be7fea8.

* chore: add maxIntervalWidth

* chore: add loading animation color

* chore: add condition to show scroll to recent button

* chore: call onScale update

* chore: crosshair related changes

---------

Co-authored-by: Ahmad Taimoor <ahmadtaimoor@Ahmad-Taimoor-Suddles-MacBook-Pro-C02YN1TNJGH6.local>
Co-authored-by: ahmadtaimoor-deriv <[email protected]>

* chore: remove unused import

* chore: add line styles for rainbow indicator

* fix: merge issues

* chore: add assert to RainbowIndicatorConfig

* feat: add combinePaths function

* chore: update document

* Update lib/src/deriv_chart/chart/data_visualization/helpers/find_intersection.dart

Co-authored-by: ramin-deriv <[email protected]>

* chore: add animation dependency to marker area

* chore: add minElapsedTimeToFollow prop

* chore: add props to customize animation duration and to show blink animation

* chore: update distant constant to fix flickering issue

* fix: indicator exception on selecting MovingAverageType

* fix: duplicate import

* refactor: make duration props non nullable

* fix: expanded index when bottom indicator is removed

---------

Co-authored-by: balakrishna-binary <[email protected]>
Co-authored-by: Ahmad Taimoor <ahmadtaimoor@Ahmad-Taimoor-Suddles-MacBook-Pro-C02YN1TNJGH6.local>
Co-authored-by: ahmadtaimoor-deriv <[email protected]>
Co-authored-by: ramin-deriv <[email protected]>
@ramin-deriv
bahar/Add drawing tool documentation (#257)
e1faa91 
* add_drawing_tool_documentation

* add more description base on review comments

* small fix

* add more description
@ramin-deriv
ramin/fix_off_screen_calculation (#253)
1f1b4cc 
* fix trend drawing off-screen calculation

* improve DraggableEdgePointExtension doc

* Fix issues after merge commit

* add repaint boundary

* remove the print statement
@ramin-deriv
fix: fix deriv_lint dependendency
c42764d
@ramin-deriv
fix: fix merge issues
5167914
@ramin-deriv
udpate technical analysis dependency
df5f4ac
@ramin-deriv
Fix merge issues
da51929
@ramin-deriv ramin-deriv force-pushed the ramin/rebase_fe_changes_with_dev_2 branch from 7e3ecef to da51929 Compare March 8, 2024 02:49
@ramin-deriv ramin-deriv changed the title Ramin/rebase fe changes with dev 2 Ramin/Update_dev_with_fe_changes Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramin-deriv @sahani-deriv @hamed-rezaee @maryia-deriv @ahmadtaimoor-deriv @balakrishna-deriv