Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osama/DERG-1441/add accumulator profit value to accumulator barriers #288

Merged
merged 29 commits into from
Jan 3, 2024
Merged

Osama/DERG-1441/add accumulator profit value to accumulator barriers #288

merged 29 commits into from
Jan 3, 2024

Conversation

osama-deriv
Copy link
Contributor

Clickup link: https://app.clickup.com/t/20696747/DERG-1441
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

ramin-deriv and others added 26 commits November 10, 2023 16:33
@ramin-deriv
add Accumulators tick indicator class and its painter
70ebd09
@ramin-deriv
add profit
1e4deb4
@ramin-deriv
paint barrier values as well
883ab8e
@ramin-deriv
feat: add high and low barrier display fields
b481fd7
@ramin-deriv
doc: add some docs to the fields in AccumulatorTickIndicator
d52197a
@ramin-deriv
add barrierSpotDistance
3a7a5a7
@ramin-deriv
add barrierEpoch
d2b7607
@osama-deriv
Merge branch 'ramin/add_accumulators_tick_indicator' into osama/add-a…
7f16e79 
…ccumulator-barriers
@osama-deriv
Create accumulator object
23b736c
@osama-deriv
Make paintBlinkingGlow more customizable
58e954d
@osama-deriv
rename folder
b693e99
@osama-deriv
Implement Accumulators Barriers
a096f0c
@osama-deriv
Improve play tick animation logic
d80b147
@osama-deriv
remove duplication
f823577
@osama-deriv
resolve minor issue
7810863
@osama-deriv
minor improvement
e939ad2
@osama-deriv
fix typo
24c4460
@osama-deriv
variable renaming
8ec2be5
@osama-deriv
renaming
2a55a73
@osama-deriv
Merge branch 'osama/add-accumulator-barriers' into osama/add-accumula…
1b820e8 
…tor-profit

# Conflicts:
#	lib/deriv_chart.dart
@osama-deriv
implement price label and blinking dot
9d4fc3a
@osama-deriv
implement the line for accumulators_indicator
081552c
@osama-deriv
make the maxCurrentTickOffset dynamic to be selected by the consumer
9caf17c
@osama-deriv
implement the profit value on accumulator tick indicator
fee7866
@osama-deriv
file format
1e3b403
@osama-deriv
fix the test
6ded98a
@ramin-deriv ramin-deriv merged commit 25d1398 into deriv-com:dev Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin-deriv ramin-deriv ramin-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osama-deriv @ramin-deriv