[REFACTORING] shontzu/CFDS-3634/add-compare-accounts-page #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shontzu-deriv
force-pushed
the
shontzu/CFDS-3634/add-compare-accounts-page
branch
from
fb6ae2e
to
5c288e9
Compare
Pull Request Test Coverage Report for Build 8842456181Details
💛 - Coveralls |
|
hasan-deriv
reviewed
Apr 25, 2024
src/cfd/components/CompareAccountsCarousel/CompareAccountsCarouselButton.tsx
Outdated
Show resolved
Hide resolved
src/cfd/screens/CFDCompareAccounts/CompareAccountsPlatformLabel.tsx
Outdated
Show resolved
Hide resolved
src/cfd/screens/CFDCompareAccounts/CompareAccountsPlatformLabel.tsx
Outdated
Show resolved
Hide resolved
src/cfd/screens/CFDCompareAccounts/InstrumentsLabelHighlighted.tsx
Outdated
Show resolved
Hide resolved
src/cfd/screens/CFDCompareAccounts/InstrumentsIconWithLabel.tsx
Outdated
Show resolved
Hide resolved
…com:shontzu-deriv/traders-hub into shontzu/CFDS-3634/add-compare-accounts-page
shontzu-deriv
force-pushed
the
shontzu/CFDS-3634/add-compare-accounts-page
branch
from
09aaa59
to
05e8363
Compare
thisyahlen-deriv
approved these changes
Apr 26, 2024
|
Preview Link: https://pr-126.traders-hub.pages.dev
|
hasan-deriv
approved these changes
Apr 26, 2024
shontzu-deriv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[REFACTORING] Add compare accounts popup as we have in production
a new repository has been initiated for tradershub v2
as the next phase of FE refactoring, tradershub v2 will be deprecated from legacy codebase
we need to migrate all tradershub-v2-related code from legacy codebase to tradershub's new standalone repository
the scope of this card is to migrate the compare-accounts related code