Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: signup modal style fix and add error msg from be #130

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore: signup modal style fix and add error msg from be #130

merged 1 commit into from
Apr 29, 2024

Conversation

thisyahlen-deriv
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Preview Link: https://pr-130.traders-hub.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@thisyahlen-deriv thisyahlen-deriv merged commit 4c368ce into deriv-com:main Apr 29, 2024
5 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8872007396

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 47.259%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/flows/Signup/PasswordSettingModal/PasswordSettingModal.tsx 1 3 33.33%
src/hooks/useNewVirtualAccount.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/flows/Signup/CitizenshipModal/CitizenshipModal.tsx 1 20.59%
Totals Coverage Status
Change from base Build 8871732475: -0.08%
Covered Lines: 1391
Relevant Lines: 2373
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisyahlen-deriv @coveralls