Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Sergei / TRAH 3146 / Add performance metrics for trader's hub new repo #81

Merged

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Apr 5, 2024

  • add @deriv-com/analytics package
  • add startInitTimers to main and create performance metrics file
  • add all possible metrics for now (except cTrader and DerivX creation, and cashier load)
  • change mutate to mutateAsync in useMT5AccountHandler hook because we need to know when the request completed

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8735589515

Details

  • 37 of 51 (72.55%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 50.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/TotalAssets/TotalAssets.tsx 10 11 90.91%
src/components/CurrencySwitcher/CurrencySwitcher.tsx 3 8 37.5%
src/utils/performance-metrics-methods.ts 12 20 60.0%
Totals Coverage Status
Change from base Build 8735007918: 0.3%
Covered Lines: 1313
Relevant Lines: 2149

💛 - Coveralls

@sergei-deriv sergei-deriv marked this pull request as ready for review April 16, 2024 12:05
Copy link

Preview Link: https://pr-81.traders-hub.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@habib-deriv habib-deriv merged commit cc26b69 into deriv-com:main Apr 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants