Skip to content

Commit

Permalink
remove duplications
Browse files Browse the repository at this point in the history
  • Loading branch information
talaharoni committed Oct 14, 2024
1 parent b8a627d commit 9c67009
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 23 deletions.
2 changes: 0 additions & 2 deletions packages/sdks/core-js-sdk/src/sdk/flow/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const withFlow = (httpClient: HttpClient) => ({
options?: Options,
conditionInteractionId?: string,
interactionId?: string,
version?: number,
componentsVersion?: string,
flowVersions?: Record<string, number>,
input?: FlowInput,
Expand All @@ -30,7 +29,6 @@ const withFlow = (httpClient: HttpClient) => ({
options,
conditionInteractionId,
interactionId,
version,
componentsVersion,
flowVersions,
input,
Expand Down
2 changes: 0 additions & 2 deletions packages/sdks/web-component/src/lib/descope-wc/DescopeWc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ class DescopeWc extends BaseDescopeWc {
},
conditionInteractionId,
'',
flowConfig.version,
projectConfig.componentsVersion,
flowVersions,
{
Expand Down Expand Up @@ -513,7 +512,6 @@ class DescopeWc extends BaseDescopeWc {
},
conditionInteractionId,
interactionId,
version,
componentsVersion,
flowVersions,
{
Expand Down
20 changes: 1 addition & 19 deletions packages/sdks/web-component/test/descope-wc.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,6 @@ describe('web-component', () => {
},
undefined,
'submitterId',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -1728,7 +1727,7 @@ describe('web-component', () => {

// Get start input is the 6th argument of the first call to start
// ensure the result is passed to the start input
const startInput = startMock.mock.calls[0][7];
const startInput = startMock.mock.calls[0][6];
expect(startInput).toEqual(
expect.objectContaining({
[`${SDK_SCRIPT_RESULTS_KEY}.${scriptId}_${resultKey}`]: resultValue,
Expand Down Expand Up @@ -1859,7 +1858,6 @@ describe('web-component', () => {
expect.objectContaining({ redirectUrl: 'http://custom.url' }),
undefined,
'',
0,
"1.2.3",
{
"otpSignInEmail": 1,
Expand Down Expand Up @@ -1897,7 +1895,6 @@ describe('web-component', () => {
}),
undefined,
'',
1,
"1.2.3",
{
"sign-in": 1,
Expand Down Expand Up @@ -2319,7 +2316,6 @@ describe('web-component', () => {
},
conditionInteractionId,
'interactionId',
1,
"1.2.3",
{
"sign-in": 1,
Expand Down Expand Up @@ -2365,7 +2361,6 @@ describe('web-component', () => {
},
undefined,
'',
1,
"1.2.3",
{
"sign-in": 1,
Expand Down Expand Up @@ -2453,7 +2448,6 @@ describe('web-component', () => {
},
undefined,
'',
1,
undefined,
{
"sign-in": 1,
Expand Down Expand Up @@ -2536,7 +2530,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2584,7 +2577,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2624,7 +2616,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2751,7 +2742,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2792,7 +2782,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2829,7 +2818,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2900,7 +2888,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"sign-in": 0,
Expand Down Expand Up @@ -2937,7 +2924,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"otpSignInEmail": 1,
Expand Down Expand Up @@ -3004,7 +2990,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"otpSignInEmail": 1,
Expand Down Expand Up @@ -3070,7 +3055,6 @@ describe('web-component', () => {
},
undefined,
'',
0,
"1.2.3",
{
"otpSignInEmail": 1,
Expand Down Expand Up @@ -3145,7 +3129,6 @@ describe('web-component', () => {
defaultOptionsValues,
undefined,
'',
1,
"1.2.3",
{
"sign-in": 1,
Expand Down Expand Up @@ -3201,7 +3184,6 @@ describe('web-component', () => {
defaultOptionsValues,
undefined,
'',
1,
"1.2.3",
{
"sign-in": 1,
Expand Down

0 comments on commit 9c67009

Please sign in to comment.