fix: issue 7394 RELEASE (#778)

## Related Issues Fixes descope/etc#7394
descope · Aug 14, 2024 · caade56 · caade56
1 parent 2605eeb
commit caade56
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/libs/sdk-mixins/src/mixins/baseStaticUrlMixin.ts b/packages/libs/sdk-mixins/src/mixins/baseStaticUrlMixin.ts
@@ -4,7 +4,7 @@ export const baseStaticUrlMixin = createSingletonMixin(
   <T extends CustomElementConstructor>(superclass: T) => {
     return class BaseStaticUrlMixinClass extends superclass {
       get baseStaticUrl() {
-        return this.getAttribute('base-static-url');
+        return this.getAttribute('base-static-url') || '';
       }
     };
   },

diff --git a/packages/libs/sdk-mixins/src/mixins/baseUrlMixin.ts b/packages/libs/sdk-mixins/src/mixins/baseUrlMixin.ts
@@ -4,7 +4,7 @@ export const baseUrlMixin = createSingletonMixin(
   <T extends CustomElementConstructor>(superclass: T) => {
     return class BaseUrlMixinClass extends superclass {
       get baseUrl() {
-        return this.getAttribute('base-url');
+        return this.getAttribute('base-url') || '';
       }
     };
   },

diff --git a/packages/sdks/web-component/test/descope-wc.test.ts b/packages/sdks/web-component/test/descope-wc.test.ts
@@ -56,7 +56,7 @@ const THEME_DEFAULT_FILENAME = `theme.json`;
 const abTestingKey = getABTestingKey();
 
 const defaultOptionsValues = {
-  baseUrl: null,
+  baseUrl: '',
   deferredRedirect: false,
   abTestingKey,
   lastAuth: {},