feat: support multi style and style prop #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bars92
changed the title
nirgur
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Looks good
added a few comments
In addition, I know it's not part of the task, but I really think we should start using the mixins also in the web component and this is a good opportunity to do it
It should simplify the code dramatically and we will not have to maintain this logic in 2 different places
WDYT? we can do it together if you like
packages/sdks/web-component/src/lib/descope-wc/BaseDescopeWc.ts
Outdated
Show resolved
Hide resolved
nirgur
approved these changes
Aug 12, 2024
2 tasks
Bars92
added a commit
that referenced
this pull request
Aug 22, 2024
## Related Issues related descope/etc#4875 ## Related PRs #744 ## Description - add styleId to react sdk - add test - add readme details ## Must - [ ] Tests - [ ] Documentation (if applicable) --------- Signed-off-by: Bar Saar <[email protected]> Co-authored-by: nirgur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://github.com/descope/etc/issues/4875
styleNameprop