Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OIDC error redirect URI #748

Merged
merged 10 commits into from
Jul 23, 2024
Merged

feat: OIDC error redirect URI #748

merged 10 commits into from
Jul 23, 2024

Conversation

orius123
Copy link
Member

Read oidc error redirect uri from the URL and pass it through to the flow

@vercel Vercel
Copy link

vercel bot commented Jul 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:42am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:42am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:42am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:42am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:42am

@orius123 orius123 changed the title OIDC error redirect URI feat: OIDC error redirect URI Jul 22, 2024
@orius123 orius123 marked this pull request as ready for review July 23, 2024 08:59
@orius123 orius123 requested a review from nirgur July 23, 2024 09:45
nirgur
nirgur reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Added a few comments

packages/sdks/web-component/src/lib/descope-wc/BaseDescopeWc.ts Outdated Show resolved Hide resolved
packages/sdks/web-component/src/lib/types.ts Outdated Show resolved Hide resolved
@orius123 orius123 requested a review from nirgur July 23, 2024 12:43
@orius123 orius123 merged commit d1701fa into main Jul 23, 2024
11 checks passed
@orius123 orius123 deleted the oidc_error_redirect_uri branch July 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirgur nirgur nirgur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orius123 @nirgur