Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom fields in user-profile-widget + Edit/Delete flows #843

Merged
merged 27 commits into from
Dec 3, 2024

Conversation

Nitzperetz
Copy link
Member

@Nitzperetz Nitzperetz commented Nov 10, 2024

Related Issues

fixes https://github.com/descope/etc/issues/8220
Part of https://github.com/descope/etc/issues/6501

Description

Widget Profile widget to support custom fields presentation - created a new mixin to support custom fields userAttribute component.

image

Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:09pm
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:09pm
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:09pm
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:09pm
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:09pm

Copy link

nx-cloud bot commented Nov 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e0cb78b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@Nitzperetz Nitzperetz changed the title Support custom fields in user-profile-widget feat: Support custom fields in user-profile-widget Nov 10, 2024
Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments
If something is not clear we can go over it together

Signed-off-by: Nitzan Peretz <[email protected]>
@Nitzperetz
Copy link
Member Author

@nirgur added subscribe to initUserCustomAttributesMixin

…/user_profile_widget_add_custom_fields' of github.com:descope/descope-js into feat/user_profile_widget_add_custom_fields
@Nitzperetz Nitzperetz enabled auto-merge (squash) December 2, 2024 18:06
@Nitzperetz
Copy link
Member Author

@nirgur updated

nirgur
nirgur previously approved these changes Dec 2, 2024
@Nitzperetz
Copy link
Member Author

@nirgur I think it might be related to pnpm.
Can you build and push your pnpm.lock file please?

@nirgur
Copy link
Collaborator

nirgur commented Dec 2, 2024

@nirgur I think it might be related to pnpm. Can you build and push your pnpm.lock file please?

done

@Nitzperetz Nitzperetz requested review from nirgur and removed request for tomerlichtash and nirgur December 3, 2024 13:32
@Nitzperetz Nitzperetz merged commit d29e1f4 into main Dec 3, 2024
11 checks passed
@Nitzperetz Nitzperetz deleted the feat/user_profile_widget_add_custom_fields branch December 3, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants