Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add permitted IPs for access key widget #852

Merged
merged 3 commits into from
Nov 24, 2024
Merged

feat: add permitted IPs for access key widget #852

merged 3 commits into from
Nov 24, 2024

Conversation

OfekAvergil
Copy link
Contributor

@OfekAvergil OfekAvergil commented Nov 21, 2024 •
edited
Loading

Related Issues

https://github.com/descope/etc/issues/8168

Related PRs

branch PR
Content https://github.com/descope/content/pull/663

Description

Added Permitted IPs field to access key creation, and a column to the Access Keys Management widget

Must

  • Tests
  • Documentation (if applicable)

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:06pm
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:06pm
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:06pm
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:06pm
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:06pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2da63ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@OfekAvergil OfekAvergil changed the title Add permitted IPs field to access key management widget Add permitted IPs to access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title Add permitted IPs to access key widget Add permitted ips to access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title Add permitted ips to access key widget add permitted ips to access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title add permitted ips to access key widget edit(widget): add permitted IPs for access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title edit(widget): add permitted IPs for access key widget add permitted IPs for access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title add permitted IPs for access key widget add permitted IPs for access key widget Nov 21, 2024
@OfekAvergil OfekAvergil changed the title add permitted IPs for access key widget feat: add permitted IPs for access key widget Nov 21, 2024
@OfekAvergil OfekAvergil requested a review from nirgur November 21, 2024 15:09
@OfekAvergil OfekAvergil merged commit b2b5bbe into main Nov 24, 2024
11 of 15 checks passed
@OfekAvergil OfekAvergil deleted the add-permission-ids-to-access-key-mgmt-widget branch November 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirgur nirgur nirgur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OfekAvergil @nirgur