fix: support react-19 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 98f272e.
☁️ Nx Cloud last updated this comment at |
nirgur
reviewed
Dec 20, 2024
...es/libs/sdk-mixins/src/mixins/createValidateAttributesMixin/createValidateAttributesMixin.ts
Show resolved
Hide resolved
nirgur
previously approved these changes
Dec 22, 2024
nirgur
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/8299
Description
The error occurs in React 19 due to changes in how React handles Custom Elements and their properties.
before (18) React was more lenient when setting properties on Custom Elements. If a property had only a getter and no setter, React would often silently fail without throwing an error.
In React 19 - react has improved its support for Custom Elements and aligns with the HTML specification. When React attempts to set a property on a Custom Element, and the property has only a getter (no setter), it throws a TypeError since it violates JavaScript’s property descriptor rules
some sources:
https://blog.logrocket.com/working-custom-elements-react
facebook/react#29037
https://codingmall.com/knowledge-base/25-global/19398-how-does-react-19-support-custom-elements-differently-from-previous-versions
another approach will be also to change getters to internal (
_getTheme) and avoid setters, might work as well