feat: Support for isDismissed from FedCM #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a9bbf39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gaokevin1
changed the title
gaokevin1
changed the title
gaokevin1
commented
Dec 16, 2024
orius123
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/8619
Related PRs
Description
Add the ability to extract Dismissed Event and Reason from the FedCM component.
This will allow you to be able to see the reason behind why a OneTap modal was skipped, whether it was induced by the user or whether the lack of a session triggered it to not show up.
This is important for analytics and tracking whether or not the OneTap component showed up because the user wasn't signed in with Google, or because the user actually closed the modal but a valid credential was found.
Must