Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Country Codes package #876

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Country Codes package #876

wants to merge 2 commits into from

Conversation

tomerlichtash
Copy link
Member

@tomerlichtash tomerlichtash commented Dec 29, 2024

Related Issues

Related https://github.com/descope/etc/issues/8022

Description

Currently, Phone Country Codes are consumed by the ConsoleApp from the Phone Component.

As part of the Components Versioning effort, we want to separate the content consumption from the component, as well as create a single source of truth of our country code list.

Must

  • Tests
  • Documentation (if applicable)

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:32am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:32am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:32am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:32am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:32am

Copy link

nx-cloud bot commented Dec 29, 2024

View your CI Pipeline Execution ↗ for commit a4f8ac6.

Command Status Duration Result
nx affected --target test:e2e ✅ Succeeded 4m 11s View ↗
nx affected --target test ✅ Succeeded 2m 33s View ↗
nx affected --target lint --fix=true ✅ Succeeded 41s View ↗
nx affected --target build ✅ Succeeded 2m 6s View ↗
nx affected --target licenseCheck ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-14 12:40:07 UTC

@tomerlichtash
Copy link
Member Author

tomerlichtash commented Dec 29, 2024

@nirgur Since the console-app consumes this directly from WCUI, I think it'll be better to separate it instead of chaining it down through flow-components and the dynamic module, so we can consume only types from the dynamic module, and not content.

I don't think this content is going to be versioned; and rather - we want to support updates to this list throughout all versions.

WDYT?

@tomerlichtash tomerlichtash changed the title Country Codes package feat: Country Codes package Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant