Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support eager refresh prop #877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asafshen
Copy link
Member

Related Issues

https://github.com/descope/etc/issues/2862

Description

support a property for eager refresh (default is true, like today)
if eagerRefreshOnFirstUseSession off, sdk only refresh if user was logged in before

few notes

  • keeping the default behavior as true even though imho a sane default is false, but we don't want to break backwards
  • lets talk about
    (a) usage of this functionality (AuthProvider vs useSession)
    (a) naming of this prop (callRefreshIfLoggedIn?)
  • if we agree on the solution - I'll write tests and implement also in other sdks (vue/angular)

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:03am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:03am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:03am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:03am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:03am

Copy link

nx-cloud bot commented Dec 30, 2024

View your CI Pipeline Execution ↗ for commit 1c6cbc2.

Command Status Duration Result
nx affected --target test:e2e ✅ Succeeded 4m 44s View ↗
nx affected --target test ✅ Succeeded 2m 51s View ↗
nx affected --target lint --fix=true ✅ Succeeded 15s View ↗
nx affected --target build ✅ Succeeded 2m 30s View ↗
nx affected --target licenseCheck ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-30 09:15:42 UTC

@asafshen asafshen requested a review from nirgur December 30, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant