Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test by installing libbz2-dev #82

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix the test by installing libbz2-dev #82

merged 1 commit into from
Jan 7, 2025

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Jan 7, 2025

No description provided.

@segasai segasai changed the title Fix the test by installlib libbz2-dev Fix the test by installing libbz2-dev Jan 7, 2025
@weaverba137
Copy link
Member

I discovered this independently just before the holidays. Within the last few weeks ubuntu-latest went from 22.04 to 24.04, and the latter does not automatically install some of the C libraries needed for fitsio, etc.

@weaverba137
Copy link
Member

PS, see desihub/desispec#2429 for a discussion of ubuntu-latest and related issues.

@segasai
Copy link
Contributor Author

segasai commented Jan 7, 2025

BTW as a person suffering from incompatibility of the desi stack with numpy 2,
I can propose to also add the test of gpu_specter with numpy 2.0.2 (the tests pass)
https://github.com/desihub/gpu_specter/tree/add_numpy2_testing
https://github.com/desihub/gpu_specter/actions/runs/12658192080

@sbailey
Copy link
Collaborator

sbailey commented Jan 7, 2025

Thanks for fixing this. +1 for adding numpy 2 testing (plus any other fixes needed to support that). Please open another PR when ready (perhaps rebasing that branch off of this newly merged PR if needed to get everything in order).

@sbailey sbailey merged commit 27cdd1b into main Jan 7, 2025
3 checks passed
@sbailey sbailey deleted the test_fix branch January 7, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants