Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CaretLineVisible default value #115

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ahmetsait
Copy link
Collaborator

Default for this property in Scintilla seems to be true, making it impossible to set it to false in the designer since it doesn't actually generate any code for default values.

@desjarlais desjarlais self-assigned this Apr 18, 2024
@desjarlais
Copy link
Owner

This looks pretty good so far in my testing, I have a couple more things to review and then I'll likely approve it soon.

Copy link
Owner

@desjarlais desjarlais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@desjarlais desjarlais merged commit a1e20db into desjarlais:master Apr 19, 2024
2 checks passed
desjarlais added a commit that referenced this pull request Apr 19, 2024
- bumped version # for upcoming release
@ahmetsait ahmetsait deleted the caret-line-highlight branch May 6, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants