Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scintilla v5.5.0 #118

Merged
merged 25 commits into from
May 6, 2024
Merged

Scintilla v5.5.0 #118

merged 25 commits into from
May 6, 2024

Conversation

ahmetsait
Copy link
Collaborator

Changes of interest:

  • Implement solution-local NuGet registry
  • Remove unused project files and put source files into project folder
  • Move build/**.dll to NuGet's special runtimes folder
  • Update Scintilla.dll & Lexilla.dll
  • Fix transparent colors
  • Fix incorrect default values
  • Implement Scintilla element APIs

@ahmetsait ahmetsait marked this pull request as ready for review May 6, 2024 10:27
@ahmetsait
Copy link
Collaborator Author

Published as ahmetsait.Scintilla5.NET for easy testing.

@desjarlais desjarlais self-assigned this May 6, 2024
@ahmetsait
Copy link
Collaborator Author

Rebased.
I know it's a lot to take at once but all changes are contained in their atomic commits for easy review so it would be phenomenal if this gets merged.

<Copyright>Copyright (c) 2018, Jacob Slusser. All rights reserved. VPKSoft, cyber960 2022, desjarlais 2023.</Copyright>
<Version>5.3.3.19</Version>
<Copyright>Copyright (c) Jacob Slusser 2018, VPKSoft, cyber960 2022, desjarlais 2023.</Copyright>
<Version>5.5.0</Version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmetsait Why use the scintilla native dll as the version number?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a good reason other than it seemed close enough and a nice round number. Agreed that they are unrelated and we shouldn't be trying to sync them.

@desjarlais desjarlais merged commit 5b518e5 into desjarlais:master May 6, 2024
2 checks passed
@ahmetsait
Copy link
Collaborator Author

Thanks a lot! Any chance of a NuGet release?

@desjarlais
Copy link
Owner

@ahmetsait I'm getting build errors with the nuget file with the cd command giving an exit code 1. One I fix that I'll work on a release.

@ahmetsait
Copy link
Collaborator Author

I might be able to fix that on my change history PR later on.

@desjarlais
Copy link
Owner

I got it fixed, ps was disabled so the ps1 was not able to run, it is good now the nuget is released

@ahmetsait ahmetsait deleted the simplify branch May 8, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants