Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ADR-016: Reactions module #898

Merged
merged 54 commits into from
Jun 21, 2022
Merged

feat: ADR-016: Reactions module #898

merged 54 commits into from
Jun 21, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 8, 2022 •
edited
Loading

Description

This PR implements ADR-016 adding the new x/reactions module.

Closes: #890

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM
added x/reactions types
beb6468 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
12bb641 
…reactions-implementation
@RiccardoM
updated ADR
d1df146 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added the query types
e3087c4 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
started to implement the keeper methods
e6b8fe2 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added MsgEditRegisteredReaction
5a4110e 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added keeper tests and improved messages and reactions
90205bf 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added external hooks tests
67a39ce 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
24993d4 
…reactions-implementation
@RiccardoM
added keeper genesis and improved hooks
5338e44 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added gRPC query methods implementation
a2e9df1 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added gRPC server tests
fefc091 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added the invariants
4df886a 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added migrations
d3524e8 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added the msg server implementation
da76992 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
1e7a83d 
…adr-016-reactions-module
@github-actions github-actions bot added the kind/adr An issue or PR relating to an architectural decision record label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #898 (20517d4) into master (887946b) will increase coverage by 0.45%.
The diff coverage is 87.67%.

❗ Current head 20517d4 differs from pull request most recent head 7bcef1b. Consider uploading reports for the commit 7bcef1b to get more accurate results

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   83.41%   83.87%   +0.45%     
==========================================
  Files         133      150      +17     
  Lines       11710    13121    +1411     
==========================================
+ Hits         9768    11005    +1237     
- Misses       1581     1728     +147     
- Partials      361      388      +27
Impacted Files Coverage Δ
x/reactions/keeper/hooks.go 20.00% <20.00%> (ø)
x/reactions/types/codec.go 43.75% <43.75%> (ø)
x/reactions/keeper/keeper.go 70.58% <70.58%> (ø)
x/reactions/keeper/alias_functions.go 73.22% <73.22%> (ø)
x/reactions/types/models.go 77.48% <77.48%> (ø)
x/reactions/keeper/external_hooks.go 80.43% <80.43%> (ø)
x/reactions/keeper/grpc_query.go 80.95% <80.95%> (ø)
x/reactions/keeper/registered_reactions.go 88.67% <88.67%> (ø)
x/reactions/keeper/genesis.go 91.11% <91.11%> (ø)
x/reactions/keeper/invariants.go 92.80% <92.80%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15fac3...7bcef1b. Read the comment docs.

@RiccardoM
added MsgServer tests
9185107 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM
added the reactions module to app.go
23c72bb 
Signed-off-by: Riccardo Montagnin <[email protected]>
@leobragaz leobragaz changed the title feat: DCD-7: ADR-016: Reactions module feat: ADR-016: Reactions module Jun 16, 2022
RiccardoM and others added 13 commits June 20, 2022 08:28
@RiccardoM @leobragaz
Update proto/desmos/reactions/v1/genesis.proto
3b0bab6 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/client/cli/tx.go
501d1d5 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/client/cli/tx.go
edbb5b1 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/keeper/msg_server.go
aab0f90 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/keeper/msg_server.go
2781304 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/keeper/reactions_test.go
85397cd 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @dadamu
Update x/reactions/types/genesis.go
7381d2f 
Co-authored-by: Paul <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/client/cli/tx.go
8fc8672 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM @leobragaz
Update x/reactions/client/cli/tx.go
54bc3ca 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM
Update x/reactions/client/cli/tx.go
98008da
@RiccardoM @leobragaz
Update x/reactions/keeper/external_hooks.go
82b3dc2 
Co-authored-by: Leonardo Bragagnolo <[email protected]>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
7951e32 
…adr-016-reactions-module
@RiccardoM
updated Proto files
0055062 
Signed-off-by: Riccardo Montagnin <[email protected]>
leobragaz
leobragaz approved these changes Jun 20, 2022
View reviewed changes
proto/desmos/reactions/v1/genesis.proto
}

// SubspaceDataEntry contains the data related to a single subspace
message SubspaceDataEntry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RiccardoM yes course

@RiccardoM RiccardoM requested a review from dadamu June 21, 2022 06:51
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jun 21, 2022
dadamu
dadamu requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dadamu dadamu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is good to me, just last thing that the cmd should be registered to module.

x/reactions/module.go Outdated

// GetTxCmd returns the root tx command for the reactions module.
func (AppModuleBasic) GetTxCmd() *cobra.Command {
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost to add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added it!

x/reactions/module.go Outdated

// GetQueryCmd returns the root query command for the reactions module.
func (AppModuleBasic) GetQueryCmd() *cobra.Command {
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added it!

@RiccardoM
added CLI commands to reactions module
84ae572 
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM requested a review from dadamu June 21, 2022 07:49
dadamu
dadamu approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go!

@mergify mergify bot merged commit 452d6bf into master Jun 21, 2022
@mergify mergify bot deleted the riccardo/adr-016-reactions-module branch June 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobragaz leobragaz leobragaz approved these changes

@dadamu dadamu dadamu approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass kind/adr An issue or PR relating to an architectural decision record x/CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the possibility of reacting to posts
3 participants
@RiccardoM @dadamu @leobragaz