Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pegasus frontend: Handle 'extra' based on command/launch lines #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicjansma
Copy link

This changes Pegasus output to handle the -e <STRING> argument and command:/launch: differently:

  • If -e was not provided (or was provided empty), utilize the existing command: OR launch: tag (which are aliases of each other, and the later is what the Metadata Generator writes)
    • Otherwise, there was no way to tell skyscraper to just use the existing pre-fab'd metadata from e.g. the Metadata Generator
  • If -e was provided, always use that
  • Always write command (or launch) last, since that is generally a multi-line command

@nicjansma
Copy link
Author

@detain are you still maintaining this fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant